Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 47d138c5cac9
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4ca5a44d0714
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Aug 4, 2017

  1. [2.4] Add default basename for Tempfile.create. 

    See ruby/ruby@64f53f0
    @headius
    headius committed Aug 4, 2017
    Copy the full SHA
    545b4fc View commit details

  2. Exclude last few items from 2.4. #4687.

    @headius
    headius committed Aug 4, 2017
    Copy the full SHA
    4ca5a44 View commit details
Showing with 4 additions and 1 deletion.
  1. +1 −1 lib/ruby/stdlib/tempfile.rb
  2. +1 −0 test/mri/excludes/TestMethod.rb
  3. +2 −0 test/mri/excludes/TestTime.rb
2 changes: 1 addition & 1 deletion lib/ruby/stdlib/tempfile.rb
View file
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@ class Tempfile
# ... do something with f ...
# end
#
def Tempfile.create(basename, tmpdir=nil, mode: 0, **options)
def Tempfile.create(basename="", tmpdir=nil, mode: 0, **options)
tmpfile = nil
Dir::Tmpname.create(basename, tmpdir, options) do |tmpname, n, opts|
mode |= File::RDWR|File::CREAT|File::EXCL
1 change: 1 addition & 0 deletions test/mri/excludes/TestMethod.rb
View file
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@
exclude :test_inspect, "fails since an alias-ed method does not distinguish owner and implementor module"
exclude :test_hash, "won't pass since Array#map is not a Array#collect alias as in MRI"
exclude :test_orphan_callee, "needs investigation"
exclude :test_prepended_public_zsuper, "2.4 fix/change to prepend + method + super_method (#4687)"
exclude :test_singleton_method, "needs investigation"
exclude :test_splat_long_array, "passes locally but fails on travis OOME"
exclude :test_super_method_removed, "finds super method when super method has been undef (#2155)"
2 changes: 2 additions & 0 deletions test/mri/excludes/TestTime.rb
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,9 @@
exclude :test_strftime_flags, "month case doesn't match, needs investigation"
exclude :test_strftime_invalid_flags, "needs investigation"
exclude :test_strftime_rational, "needs investigation"
exclude :test_strftime_seconds_from_epoch, "Integer unification, needs Bignum support (#4687)"
exclude :test_strftime_too_wide, "needs investigation"
exclude :test_strftime_year, "Integer unification, needs Bignum support (#4687)"
exclude :test_time_interval, "needs investigation"
exclude :test_utc_or_local, "needs investigation"
exclude :test_xmlschema, "raising Joda errors recently, #2237"