Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: smoltcp-rs/smoltcp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 53a3875452f8
Choose a base ref
...
head repository: smoltcp-rs/smoltcp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5bf64586cd29
Choose a head ref
  • 2 commits
  • 21 files changed
  • 1 contributor

Commits on Jul 27, 2017

  1. Remove useless redundant tests.

    @whitequark
    whitequark committed Jul 27, 2017
    Copy the full SHA
    1a11e4d View commit details

  2. Get rid of Result<_, ()>. 

    The use of this type has several drawbacks:
  * It does not allow distinguishing between different error
    conditions. In fact, we wrongly conflated some of them
    before this commit.
  * It does not allow propagation via ? and requires manual use
    of map_err, which is especially tiresome for downstream code.
  * It prevents us from expanding the set of error conditions
    even if right now we have only one.
  * It prevents us from blanket using Result<T> everywhere
    (a nitpick at most).

Instead, use Result<T, Error> everywhere, and differentiate error
conditions where applicable.
    @whitequark
    whitequark committed Jul 27, 2017
    Copy the full SHA
    5bf6458 View commit details
Loading