Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin stdenv: Ensure libSystem reexports the right libraries #27645

Merged
merged 1 commit into from Jul 25, 2017
Merged

darwin stdenv: Ensure libSystem reexports the right libraries #27645

merged 1 commit into from Jul 25, 2017

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jul 25, 2017 •
edited

Motivation for this change

The logic was made pure for the normal libSystem, but this change never made it to the bootstrap tools. Deduplicating the logic as the comment suggests would have prevented this, but here's a stop-gap until we do so.

Things done

Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS -- in progress
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314
darwin stdenv: Ensure libSystem reexports the right libraries
98cff3f 
The logic was made pure for the normal libSystem, but this change never
made it to the bootstrap tools. Deduplication the logic as the comment
suggests would have prevented this, but here's a stop-gap until we do
so.
@Ericson2314
Copy link
Member Author

I built it locally.

@Ericson2314 Ericson2314 added the 6.topic: darwin Running or building packages on Darwin label Jul 25, 2017
@Ericson2314 Ericson2314 merged commit 98cff3f into NixOS:staging Jul 25, 2017
@Ericson2314 Ericson2314 deleted the libSystem-reexport-purity branch July 25, 2017 20:01
@LnL7 LnL7 mentioned this pull request Jul 28, 2017
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees

@copumpkin copumpkin

Labels
1.severity: mass-darwin-rebuild 6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @LnL7 @copumpkin