lib/string: added parseDomain and parseEmail #27648
Conversation
|
@taktoa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @zimbatm and @Profpatsch to be potential reviewers. |
| b = builtins; | ||
| regex = "^([^.@][^@]*[^.@]|[^.@])@([^.@][^@]*[^.@]|[^.@])$"; | ||
| matched = b.match regex email; | ||
| mayFail = b.tryEval ( |
There was a problem hiding this comment.
Please don't use tryEval, it's a horrible function with poorly specified semantics that are not a good match for a purely functional language. It seems to me that an if-then-else would work just as well as a series of assertions.
There was a problem hiding this comment.
I'll remove it. Couldn't resist the Maybe monad style that it allows 😄
|
Ping on status? |
|
Sorry I haven't been working on this; I'm pretty busy with my senior thesis until May 10th. |
|
@taktoa any motivation to continue with this PR? |
Motivation for this change
This adds two functions to
lib.strings:parseDomainandparseEmail, which parse domains and emails under RFC 1035 and RFC 5322 respectively (the email parser accepts a superset of what is allowed under RFC 5322, but the domain parser should be tight).I found myself in need of functions to parse domains and emails, so I thought I would upstream what I wrote.
Things done
lib/tests/misc.nix.nix-build lib/tests/release.nix.