check_ssl_cert: init at 1.51.0 #28069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
reviewed
Aug 9, 2017
| name = "check_ssl_cert-${version}"; | ||
| version = "1.51.0"; | ||
|
|
||
| src = fetchgit { |
There was a problem hiding this comment.
Should use the dedicated fetchFromGitHub
|
|
||
| src = fetchgit { | ||
| url = https://github.com/matteocorti/check_ssl_cert; | ||
| rev = "4e31a82008a48cd6efb82914e0bb1e136b339a31"; # v1.51.0 |
There was a problem hiding this comment.
rev = "v${version}" will do too
There was a problem hiding this comment.
awesome, didn't know that! your solution is so much better.
| }; | ||
|
|
||
| buildInputs = [ makeWrapper file ]; | ||
| #nativeBuildInputs = [ makeWrapper ]; |
There was a problem hiding this comment.
Should be removed, although I don't actually know where makeWrapper should be
| @@ -0,0 +1,33 @@ | |||
| { pkgs, openssl }: | |||
| #with import <nixpkgs> {}; | |||
|
Repushed in fd6e51d, sorry for the confusion |
globin
pushed a commit
that referenced
this pull request
Aug 9, 2017
|
Thanks. Any more action I have to take? |
|
Nope fine now |
|
thanks for the help everyone, sorry i didn't see the issues you had to fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added package for nagios plugin check_ssl_cert