Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages cleanup #28059

Closed
wants to merge 23 commits into from
Closed

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Aug 9, 2017

Motivation for this change

Since vulnix depends on ZODB 5 I wanted to look into what would be required to bump that package in pythonPackages.

During this I discovered that a ton of packages related to Zope are not building on Python 3.6 and are several years out of date.

Here is what's been done in this PR and my rationale behind it:

  • Removed subunit dependency for zope_testrunner

Since latest release it no longer depends on this module

  • Removed aiohttp-cors dependency on zodb3

Never depended on zodb3, I'm guessing copy-paste error

  • Dropped zope_browserresource

Lagging behind upstream by 4 years and not depended upon by any package

  • Dropped zope_container

Lagging behind upstream by 3 years and not depended upon by any package

  • Dropped almir

Looks abandoned to me, not updated since 2014

  • Dropped zope_sqlalchemy

Previously only depended upon by almir and lagging behind upstream by 1 year

  • Dropped zope_traversing

Lagging behind upstream by 3 years and not depended on by any packages

  • Dropped zope_publisher

Lagging behind upstream by 6 years and not depended on by any packages
Has new major release

  • Dropped zope_browser

Not updated since 2014, looks abandoned

  • Dropped zope_security

3 years behind upstream

  • Dropped zodb3

No longer depended upon by any packages

  • Dropped zope_tales

No longer depended upon by any packages, no upstream updates since 2015, no nixpkgs updates since 2013

  • Dropped pyramid_zodbconn

3 years behind upstream, not depended upon by anything

  • Dropped zodburi

3 years behind upstream, not depended upon by anything

  • Dropped ZEO

4 years behind upstream, not depended upon by anything
Upstream has since released a new major version

  • Dropped pyramid_mailer

3 years behind upstream, not depended upon by anything

  • Dropped repoze_sendmail

4 years behind upstream, not depended upon by anything

  • Dropped hypatia

Not updated since 2014, looks abandoned

  • Dropped pyramid_tm

4 years and 2 major releases behind upstream, not depended upon by anything

  • Updated pecan

Not building

  • Updated transaction

One major release behind and depended upon by ZODB

  • Updated ZODB to latest major version

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @domenkozar @cillianderoiste

@adisbladis adisbladis requested a review from FRidh as a code owner August 9, 2017 05:46
@FRidh
Copy link
Member

FRidh commented Aug 9, 2017

Thanks! Its good to get rid of that old muck. Is this causing a lot of rebuilds, that you based it on staging?

@FRidh FRidh self-assigned this Aug 9, 2017
@adisbladis
Copy link
Member Author

When I started out I thought it was going to cause a lot of rebuilds but it it might not in the end.
It's easy enough to rebase it off master if you want me to.

@FRidh FRidh changed the base branch from staging to master August 9, 2017 12:48
@FRidh FRidh changed the base branch from master to staging August 9, 2017 12:48
@FRidh
Copy link
Member

FRidh commented Aug 9, 2017

I've pushed your commits to master.

@FRidh FRidh closed this Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants