Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-231: Add wrapper for fetch_multiple_places for a single MBID #146

Merged
merged 1 commit into from Aug 11, 2017

Conversation

ferbncode
Copy link
Member

Added wrapper _get_place_by_gid for calling fetch_multiple_places for a single MBID.

@alastair
Copy link
Collaborator

This looks OK to me, however if there are no pages which use the multiple version, do we need the added complexity that it brings? (I seem to recall that I asked this previously, so I guess we decided to keep it)

@ferbncode
Copy link
Member Author

The /review pages require fetching information for multiple entities. Since, these pages make a number of requests to the web-service presently, the fetch_multiple_* functions are added to fetch multiple entities in less time.

@alastair
Copy link
Collaborator

Right, I had a memory that this was the case, no problem

Copy link
Contributor

@gentlecat gentlecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better now. 👍

@gentlecat
Copy link
Contributor

One thing: There's no need to mention CB-231 since it's not directly related to this change.

@gentlecat gentlecat merged commit 3109872 into metabrainz:master Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants