mpDris2: add mutagen for cover art support #28063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@casey, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pjones, @FRidh and @dsprenkels to be potential reviewers. |
Mic92
reviewed
Aug 11, 2017
pkgs/tools/audio/mpdris2/default.nix
Outdated
| @@ -16,7 +16,7 @@ stdenv.mkDerivation rec { | |||
| ''; | |||
|
|
|||
| buildInputs = [ intltool autoreconfHook pythonPackages.wrapPython ]; | |||
| propagatedBuildInputs = with pythonPackages; [ python pygtk dbus-python ]; | |||
| propagatedBuildInputs = with pythonPackages; [ python pygtk dbus-python mutagen ]; | |||
There was a problem hiding this comment.
this only works, when you are in a nix-shell.
Otherwise you will see the following:
$ /nix/store/123j3zdik295fjnbgcrlsrf5zmgx97vk-mpDris2/bin/mpDris2
...
2017-08-11 23:40:27,583 .mpDris2-wrapped INFO: Mutagen not available, covers in music files will be ignored.
...
There was a problem hiding this comment.
propagatedBuildInputs will propagate all elements of this list to other derivations, using this derivation in buildInputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building mpDris2 with mutagen allows it to extract cover art from songs.
I added mutagen as a build input; mpDris2 autodetects this and enables cover art support.
I tested it with:
nix-shell --option build-use-sandbox true -I nixpkgs=. -p mpdris2And confirmed that cover art support was enabled.
The reason why some packages are in
propagatedBuildInputsand some are inpythonPathis a bit mysterious to me, but I tested if it worked without putting mutagen inpythonPathand it was fine, so I left it out.nix-shell -p nox --run "nox-review wip"./result/bin/)