Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea-ultimate: 2017.1.5 -> 2017.2.1 #28071

Merged
merged 1 commit into from Aug 10, 2017

Conversation

karolchmist
Copy link
Member

Motivation for this change

New version came out with many improvements: http://www.jetbrains.com/idea/whatsnew/#v2017-2

Used it for a day and it seems to work well.

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@karolchmist, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edwtjo, @volth and @stesie to be potential reviewers.

@NeQuissimus NeQuissimus merged commit debbd82 into NixOS:master Aug 10, 2017
@karolchmist karolchmist deleted the idea-ultimate-2017.1.2 branch August 11, 2017 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants