mpd: add lame support #28068
Merged
mpd: add lame support #28068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
commented
Aug 9, 2017
| @@ -105,6 +107,7 @@ in stdenv.mkDerivation rec { | |||
| (mkFlag mmsSupport "mms") | |||
| (mkFlag mpg123Support "mpg123") | |||
| (mkFlag aacSupport "aac") | |||
| (mkFlag lameSupport "lame-encoder") | |||
There was a problem hiding this comment.
This is in regard to all flags passed to ./configure: A lot of them are on "auto" mode, turning themselves on when the respective library is found. I don't know the rationale of passing these flags explicitly, so I'd remove those.
infinisil
commented
Aug 9, 2017
| @@ -72,6 +73,7 @@ in stdenv.mkDerivation rec { | |||
| ++ opt mmsSupport libmms | |||
| ++ opt mpg123Support mpg123 | |||
| ++ opt aacSupport faad2 | |||
| ++ opt lameSupport lame | |||
There was a problem hiding this comment.
To keep in line with the other lines, I decided to use lame instead of lame.lib. All of them not using the .lib variant, building mpd requires downloading docs and bins for all of these.
|
I'll probably make a separate PR regarding my two comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
mp3 lame is one of the two encodings supported by the mpd httpd server, the other being vorbis. As I discovered, a lot of players don't like vorbis, the Sonos sound system being one of them.
Things done
Having a working mpd server streaming via HTTP to my Sonos system, I can confirm that it definitely works.
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)