Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP::Response: set default cookie domain #4814

Closed

Conversation

icyleaf
Copy link
Contributor

@icyleaf icyleaf commented Aug 9, 2017

Support rfc2665#5.2.3:

  1. If domain attribute is empty, set request domain
  2. Support the first character of the attribute-value string is "."
  3. Convert the cookie-domain to lower case

@sdogruyol
Copy link
Member

Ping 👍

@icyleaf
Copy link
Contributor Author

icyleaf commented Sep 14, 2017

Ping?

It can not manage all request cookies for each domain if response was not set the domain, and it cant be use same cookies with same domain, or implement like requests.Session

@asterite
Copy link
Member

Can this be done without modifying the Response object? I don't understand why we need to add a domain attribute.

For example I can't see such attribute in Ruby's Net::HTTPResponse. I also can't see it in Go's http.

Maybe there's a different, more unobtrusive way to accomplish this?

@icyleaf icyleaf closed this Sep 15, 2017
@asterite
Copy link
Member

@icyleaf It would be nice to know why you closed this (how you solved it)

@icyleaf
Copy link
Contributor Author

icyleaf commented Sep 15, 2017

@icyleaf icyleaf deleted the support/default_cookie_domain branch July 6, 2018 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants