Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniupnpc: fix on darwin #28056

Merged
merged 1 commit into from Aug 9, 2017
Merged

miniupnpc: fix on darwin #28056

merged 1 commit into from Aug 9, 2017

Conversation

matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Aug 9, 2017 •
edited

For some reason miniupnpc needs libtool for static linking. Probably not ideal
but it’s doing similar on other platforms as well (using ar).

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Mic92, @roconnor and @fpletz to be potential reviewers.

@matthewbauer matthewbauer force-pushed the miniupnpc-fix branch 2 times, most recently from bf72ec1 to 6161983 Compare August 9, 2017 05:12
@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Aug 9, 2017
@Mic92
Copy link
Member

Mic92 commented Aug 9, 2017

hydra complains about an evaluation error in miniupnpc

@LnL7
Copy link
Member

LnL7 commented Aug 9, 2017

That's caused by with stdenv.lib.platforms; darwin because a darwin variable is already in scope.

@LnL7
Copy link
Member

LnL7 commented Aug 9, 2017

The binary doesn't work for me.

/nix/store/1hg5k2yfwicf9n1iqwsxj7g628fm64r5-miniupnpc-1.9.20160209/bin/upnpc
dyld: Library not loaded: /usr/lib/libminiupnpc.16.dylib
  Referenced from: /nix/store/1hg5k2yfwicf9n1iqwsxj7g628fm64r5-miniupnpc-1.9.20160209/bin/upnpc
  Reason: image not found
Trace/BPT trap: 5

@matthewbauer
miniupnpc: fix on darwin
c7f1414 
For some reason miniupnpc needs libtool for static linking. Probably not ideal
but it’s doing similar on other platforms as well (using ar).
@matthewbauer
Copy link
Member Author

Fixed

@LnL7 LnL7 merged commit e5f0c4f into NixOS:master Aug 9, 2017
@matthewbauer matthewbauer deleted the miniupnpc-fix branch February 22, 2019 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewbauer @mention-bot @Mic92 @LnL7