Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtorrentRasterbar 1.1.1 -> 1.1.4 #28061

Merged
merged 2 commits into from Aug 11, 2017

Conversation

grantwwu
Copy link
Contributor

@grantwwu grantwwu commented Aug 9, 2017

Motivation for this change

Bump the libtorrentRasterbar version from 1.1.1 to 1.1.4; fixes some version mismatch bugs on startup in Deluge.

Add a note to libtorrent that it is not the same thing as libtorrentRasterbar - this conflation wasted about an hour of my time as I made #28058

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@grantwwu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @fpletz and @ebzzry to be potential reviewers.

@grantwwu grantwwu force-pushed the bump_libtorrentRasterbar_1.1.4 branch 2 times, most recently from b57fff1 to 925c7e6 Compare August 9, 2017 07:44
@grantwwu grantwwu force-pushed the bump_libtorrentRasterbar_1.1.4 branch from 925c7e6 to e77068d Compare August 10, 2017 02:21
@FRidh FRidh merged commit d8f08bb into NixOS:master Aug 11, 2017
@grantwwu grantwwu deleted the bump_libtorrentRasterbar_1.1.4 branch August 16, 2017 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants