Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

busybox: 1.27.0 -> 1.27.1 #27746

Merged
merged 1 commit into from Jul 29, 2017
Merged

busybox: 1.27.0 -> 1.27.1 #27746

merged 1 commit into from Jul 29, 2017

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Update

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@NeQuissimus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexanderkjeldaas, @edolstra and @wkennington to be potential reviewers.

@globin globin merged commit 06a513e into NixOS:master Jul 29, 2017
@NeQuissimus NeQuissimus deleted the busybox_1_27_1 branch July 29, 2017 21:47
@vcunat
Copy link
Member

vcunat commented Aug 13, 2017

@NeQuissimus: the update to 1.27.0 (50831d5) broke our linux bootstrap tools, and this bump didn't fix them. Now it's blocking the nixpkgs-unstable channel, so I think we should revert to 1.26.x if we don't find another solution within days. I personally don't expect to put much more of my time into this.

Test command: nix-build pkgs/top-level/release.nix -A stdenvBootstrapTools.x86_64-linux

vcunat referenced this pull request Aug 13, 2017
@vcunat
release.nix: resurrect stdenvBootstrapTools
332a60c 
13d6681 crippled it unintentionally.
Also remove the incorrect/non-existing stdenv.i686-linux;
building the bootstrap tools should be a good-enough test anyway.
@NeQuissimus
Copy link
Member Author

Interesting... and very curious... Unfortunately, I don't know much about our stdenv/bootstrapping and will be away for a while. Feel free to revert. If anybody finds the issue with this, please do ping me as I'd love to understand more about it.

vcunat added a commit that referenced this pull request Aug 13, 2017
@vcunat
busybox: downgrade 1.27.1 -> 1.26.2
9c3702a 
... to fix our bootstrap tools until we find what exactly is wrong.
This effectively reverts 06a513e and 50831d5.
Discussion thread: #27746.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NeQuissimus @mention-bot @vcunat @globin