Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version check is too restrictive. #62

Closed
cpansprout opened this issue Jul 29, 2017 · 0 comments
Closed

Version check is too restrictive. #62

cpansprout opened this issue Jul 29, 2017 · 0 comments

Comments

@cpansprout
Copy link

Inline::MakeMaker requires the module’s version number to be exactly of the form #.##.

    croak <<END unless $version =~ /^\d\.\d\d$/;
Invalid version '$version' for $name.
Must be of the form '#.##'. (For instance '1.23')
END

This is too restrictive to be used with some modules. Is there any reason this validation needs to be done at all? It is true there needs to be a version for the XS_VERSION_BOOTCHECK to work, but if the version number is invalid, then that will fail. So why does Inline itself need to validate the version number?

nrdvana added a commit to nrdvana/inline-pm that referenced this issue Jun 21, 2018
Inline and Inline::MakeMaker both want the VERSION of the module
to match #.##, but this isn't convenient for developer releases with '_'.
(and previously, they disagreed on whether additional digits were allowed)

There doesn't seem to be any technical limitation on the underscore
numbers, so relax the regexes and update the error messages.

Fixes ingydotnet#62
nrdvana added a commit to nrdvana/inline-pm that referenced this issue Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant