Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fgallery: enable face detection #27741

Closed
wants to merge 2 commits into from
Closed

fgallery: enable face detection #27741

wants to merge 2 commits into from

Conversation

rycee
Copy link
Member

@rycee rycee commented Jul 29, 2017

Motivation for this change

To enable face detection in fgallery. I also bumped the package to the latest version.

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@rycee, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bjornfor, @Baughn and @abbradar to be potential reviewers.

@rycee
Copy link
Member Author

rycee commented Jul 29, 2017

Thanks @bjornfor! I've rebased this into master in 9d4d629.

@rycee rycee closed this Jul 29, 2017
@rycee rycee deleted the bump/fgallery branch July 29, 2017 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rycee @mention-bot @bjornfor