Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postfix service: fix extraMasterConf #27755

Merged
merged 1 commit into from Jul 30, 2017
Merged

postfix service: fix extraMasterConf #27755

merged 1 commit into from Jul 30, 2017

Conversation

sshisk
Copy link
Contributor

@sshisk sshisk commented Jul 29, 2017

Motivation for this change

Fix broken configuration option.

BTW, there should be a change in the changelog about new escaping of parameters. I had destination = [ "$mydomain" ]; in my configuration before and it silently broke my server after update.

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz fpletz requested a review from qknight July 29, 2017 23:00
@fpletz
Copy link
Member

fpletz commented Jul 29, 2017

cc @uwap

@fpletz fpletz added 0.kind: regression Something that worked before working no longer 6.topic: nixos labels Jul 29, 2017
@fpletz fpletz added this to the 17.09 milestone Jul 29, 2017
@qknight qknight merged commit e79d11b into NixOS:master Jul 30, 2017
@qknight
Copy link
Member

qknight commented Jul 30, 2017

oh, just wanted to check the 'review ok' button but then merged it.

anyways, thanks for the PR ;-)

@uwap
Copy link
Contributor

uwap commented Jul 30, 2017

Thanks for that fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qknight qknight Awaiting requested review from qknight

Assignees
No one assigned
Labels
0.kind: regression Something that worked before working no longer 6.topic: nixos
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sshisk @fpletz @qknight @uwap