alacritty: use patchelf instead of LD_LIBRARY_PATH #27737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use LD_LIBRARY_PATH then anything typed into Alacritty inherits it. This breaks a lot of applications if the versions are different. For me this breaks everything from Git to every program which uses Gtk.
|
@puffnfresh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Mic92 to be a potential reviewer. |
8 tasks
fpletz
approved these changes
Jul 29, 2017
Mic92
reviewed
Jul 29, 2017
| ''; | ||
|
|
||
| dontPatchELF = true; |
There was a problem hiding this comment.
If we go this route by using patchelf the platform should also exclude darwin. The current build fails anyway: https://hydra.nixos.org/eval/1378396?filter=alacritty&compare=1378360&full=
the darwin build fails at the moment and since we are now using patchelf it would not build anyway.
|
Thanks @Mic92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use LD_LIBRARY_PATH then anything typed into Alacritty inherits it. This
breaks a lot of applications if the versions are different. For me this breaks
everything from Git to every program which uses Gtk.
Motivation for this change
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)