Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awesome: 4.1 -> 4.2 #27739

Merged
merged 1 commit into from Jul 29, 2017
Merged

awesome: 4.1 -> 4.2 #27739

merged 1 commit into from Jul 29, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jul 29, 2017

Motivation for this change

  • Update to version 4.2

  • Remove 1639.patch, which has been integrated in release.

  • See Release notes.

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@romildo
awesome: 4.1 -> 4.2
47689bf 
- update to version 4.2
- remove 1639.patch, which has been integrated in release
@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ndowens, @aristidb and @vcunat to be potential reviewers.

@Mic92 Mic92 merged commit a5e8ef5 into NixOS:master Jul 29, 2017
@romildo romildo deleted the upd.awesome branch July 30, 2017 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @mention-bot @NeQuissimus @Mic92