[staging] binutils: 2.28 -> 2.29 #27744
Conversation
Binutils 2.29 no longer allows .semver symbols, which is why we need to patch glibc to avoid them
|
@NeQuissimus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @edolstra and @Ericson2314 to be potential reviewers. |
|
We might want to test this on a seperate jobset first, binutils updates have been quite problematic in the past sometimes.. |
|
@globin Could you do that? I have no idea how :D |
|
I'd like to wait for hydra to calm down a bit and finish building staging first.. Hopefully in 2-3 days |
| @@ -0,0 +1,65 @@ | |||
| From 0edeadc0d396aa713b808ae50a0058aca5d3837e Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
Is there an external source for this patch?
There was a problem hiding this comment.
yeah, it's linked below, https://sourceware.org/bugzilla/show_bug.cgi?id=21666
|
Makes sense, according to nox-review, this will basically trigger a rebuild of everything... I did not bother scrolling all the way through, but definitely a mass-rebuild :D |
|
Yes, binutils is in the stdenv => full rebuild |
|
Oh, poor Hydra with 150k queued jobs xD |
|
The x86_64-linux jobs seem fine. For i686 I noticed |
|
That just timed out I think, restarting them.. |
|
Hmm can't seem to restart them.. |
|
This looks good. |
|
libpng-apng on aarch64 seems to be broken due to this: https://nix-cache.s3.amazonaws.com/log/vk4yhbzpc3811sd2pxw7isw8lfjlv685-libpng-apng-1.6.30.drv |
|
Follow-up in 0e18f28 |
|
For reference, libpng problem seems unrelated and had been fixed on staging ba68231. |
|
@vcunat thanks! |
.semver symbols are no longer allowed, so we need to patch glibc to avoid them
See https://sourceware.org/bugzilla/show_bug.cgi?id=21666
Motivation for this change
Update
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)