Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keybase: 1.0.22 -> 1.0.27-20170726114412.8169d66 #27936

Closed
wants to merge 2 commits into from
Closed

keybase: 1.0.22 -> 1.0.27-20170726114412.8169d66 #27936

wants to merge 2 commits into from

Conversation

evujumenuk
Copy link

As indicated in https://news.ycombinator.com/item?id=14926441, Keybase's client and kbfs releases are not tagged in a consistent way. (For example, the newest tagged release is 1.0.22.) In Keybase's POV, the best way for unsupported distributions to package Keybase software is mangling their binary releases so as to ensure that built code has passed the defined CI pipeline.

AFAICT, this is already done for keybase-gui in Nixpkgs.

Until keybase in Nixpkgs is reworked, it seems silly to keep the package version at 1.0.22. Let's use a version "blessed" by "Keybase Linux Build" in https://aur.archlinux.org/packages/keybase-git/ – in this case, 1.0.27+15115, or commit 8169d666e2a4d920da7025170baccde336fce11d – and go from there. No dependencies (apart from gtk2, ostensibly for the -gui portion) have been added since 1.0.21/1.0.22.

Motivation for this change
Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

keybase: 1.0.22 -> 1.0.27-20170726114412.8169d66
77bb7e3 
As indicated in https://news.ycombinator.com/item?id=14926441, Keybase's client and kbfs releases are not tagged in a consistent way. (For example, the newest tagged release is 1.0.22.) In Keybase's POV, the best way for unsupported distributions to package Keybase software is mangling their binary releases so as to ensure that built code has passed the defined CI pipeline.

AFAICT, this is already done for keybase-gui in Nixpkgs.

Until keybase in Nixpkgs is reworked, it seems silly to keep the package version at 1.0.22. Let's use a version "blessed" by "Keybase Linux Build" in https://aur.archlinux.org/packages/keybase-git/ – in this case, 1.0.27+15115, or commit 8169d666e2a4d920da7025170baccde336fce11d – and go from there. No dependencies (apart from gtk2, ostensibly for the -gui portion) have been added since 1.0.21/1.0.22.
Mic92
Mic92 reviewed Aug 6, 2017
View reviewed changes
pkgs/tools/security/keybase/default.nix Outdated
@@ -12,8 +12,8 @@ buildGoPackage rec {
src = fetchFromGitHub {
owner = "keybase";
repo = "client";
rev = "v${version}";
sha256 = "1642d11gjgkdklppmm1j3vwc2r3qg9qqw5x07jnqs819i57mr47f";
rev = "8169d666e2a4d920da7025170baccde336fce11d";
Copy link
Member

@Mic92 Mic92 Aug 6, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a short explanation from your pull request here as well, so future maintainers know which version to update to.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2227d03 has been added to implement this. I tried keeping the explanation succinct; is anything missing?

@tad-lispy
Copy link

Beginner's question: how can I install and test this?

@fpletz fpletz added this to the 17.09 milestone Aug 30, 2017
@fpletz
Copy link
Member

fpletz commented Aug 30, 2017

There is a merge conflict now. @evujumenuk could you please resolve it so we can get this into 17.09?

@joachifm
Copy link
Contributor

This PR seems to have been obsoleted by ef3cb5c

@fpletz
Copy link
Member

fpletz commented Sep 19, 2017

Yup. :)

@fpletz fpletz closed this Sep 19, 2017
@evujumenuk
Copy link
Author

Sorry for the delay; yes, https://github.com/keybase/client does appear to be tagged more reliably nowadays (and https://github.com/keybase/kbfs hasn't even had a release yet), so a lot of what this PR does is not necessary for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict 8.has: package (update) 9.needs: community feedback
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@evujumenuk @tad-lispy @fpletz @joachifm @Mic92 @NeQuissimus