QT5.6: Fixes compile error with wrong LD env variable #27940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
globin
requested changes
Aug 5, 2017
| @@ -103,6 +103,8 @@ stdenv.mkDerivation { | |||
| preConfigure = '' | |||
| export LD_LIBRARY_PATH="$PWD/lib:$PWD/plugins/platforms:$LD_LIBRARY_PATH" | |||
| export MAKEFLAGS=-j$NIX_BUILD_CORES | |||
| // We need to set LD to GCC or otherwise we get nasty compile errors | |||
| export LD=$GCC | |||
There was a problem hiding this comment.
This shoukd be $CC otherwise this will break with clang
|
Fixed :) |
NeQuissimus
approved these changes
Aug 5, 2017
NeQuissimus
added
6.topic: cross-compilation
FRidh
requested changes
Aug 6, 2017
There was a problem hiding this comment.
Still seems to fail with
/build/qtbase-opensource-src-5.6.2/lib/libQt5Bootstrap.a(qlatincodec.o):(.data.rel.ro._ZTI12QLatin1Codec[_ZTI12QLatin1Codec]+0x0): undefined reference to `vtable for __cxxabiv1::__si_class_type_info'
/build/qtbase-opensource-src-5.6.2/lib/libQt5Bootstrap.a(qlatincodec.o):(.data.rel.ro._ZTI13QLatin15Codec[_ZTI13QLatin15Codec]+0x0): undefined reference to `vtable for __cxxabiv1::__si_class_type_info'
collect2: error: ld returned 1 exit status
| @@ -103,6 +103,8 @@ stdenv.mkDerivation { | |||
| preConfigure = '' | |||
| export LD_LIBRARY_PATH="$PWD/lib:$PWD/plugins/platforms:$LD_LIBRARY_PATH" | |||
| export MAKEFLAGS=-j$NIX_BUILD_CORES | |||
| // We need to set LD to CC or otherwise we get nasty compile errors | |||
QT uses -Wl linker flags and these flags only work with gcc/g++ and not with LD directly.
|
Now it finally should work! First I hard $GCC and replaced that with $CC, but it needed to be $CXX. :) On my laptop it compiled now with my latest commit. |
FRidh
approved these changes
Aug 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QT uses -Wl linker flags and these flags only work with gcc/g++
and not with LD directly.
Motivation for this change
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)