-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haml-lint hangs with JRuby 9.1.12.0 #4734
Comments
We need more information or an easy way to reproduce. When it's obvious it's hanging, you can grab a dump of all threads with Ctrl+\ on *nix or Ctrl+Break on Windows. Link us a gist of that output. You might also try bumping up the JVM memory by passing -J-Xmx###M where ### is something larger than the default 500M we cap the VM at. |
@headius OK, here's the dump: https://gist.github.com/HarlemSquirrel/d4a135c0c8d0cc3dd2b7f3683611f310 I'm going to try to run now with more memory. |
No improvement increasing memory up to 1024M. She still hangs and seems to spend the most time on |
@HarlemSquirrel The next obvious thing to ask would be to bisect JRuby until you figured out which commit causes this. I know that sucks but I did not see anything jump out at me in that gist. |
@enebo OK, my first investigation has been to try all JRuby versions from 9.1.7.0 - 9.1.12.0 and it seems like the issues starts with version 9.1.9.0. https://gist.github.com/HarlemSquirrel/34a14f7e6c2a8de9fb1fb12484c96b3c So I guess the issue is somewhere in 9.1.8.0...9.1.9.0 |
I starting working on the bisect but am having issues running haml-lint during the bisect.
Here's what I'm running git bisect start tags/9.1.9.0 tags/9.1.8.0
git bisect run sh haml_lint_bisect.sh The script that runs each time #!/bin/sh
export JRUBY_OPTS='--dev'
./mvnw
bin/jruby -S gem install haml_lint
timeout 10 bin/jruby -S haml-lint ../services-directory/app/views/layouts/_flash_messages.html.haml Update
|
@HarlemSquirrel I think you may need to change that to ./mvnw cleaan; ./mvn since it may be packaging. Many times we can incrementally build and it all works but I am guessing something is not getting packaged properly. |
@enebo I just discovered this too after reading https://github.com/jruby/jruby/blob/master/BUILDING.md#clean-build. I needed to clean before each new build. |
Looks like I've found the commit
|
pure-Ruby was loading and not our native extension.
@HarlemSquirrel Your bisect made this trivial. A merge did not happen correctly and we stopped loading the native extesion version of racc. Can you please verify the problem you are seeing is gone (there were some other changes in that commit)? |
@enebo Nice! haml-lint is working beautifully with JRuby built from master this morning! 🎊 |
Environment
Expected Behavior
With JRuby 9.1.7.0
haml-lint
runs as expected in a few secondsActual Behavior
Command runs extremely slowly or hangs until ^C is issued when running with 9.1.12.0.
I also opened this issue with haml-lint
sds/haml-lint#257
The text was updated successfully, but these errors were encountered: