Fix some KDE applications #27931
Merged
Fix some KDE applications #27931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @FRidh |
NeQuissimus
approved these changes
Aug 5, 2017
FRidh
reviewed
Aug 5, 2017
pkgs/applications/kde/gwenview.nix
Outdated
| @@ -17,5 +17,5 @@ mkDerivation { | |||
| baloo exiv2 kactivities kdelibs4support kio libkdcraw lcms2 libkipi phonon | |||
| qtimageformats qtsvg qtx11extras | |||
| ]; | |||
| propagatedUserEnvPkgs = [ kipi-plugins ]; | |||
| propagatedUserEnvPkgs = [ kipi-plugins libkipi kinit.bin ]; | |||
There was a problem hiding this comment.
Nitpick, but it may be better to use lib.getBin kinit because that will always return an output, even when say in the future kinit is modified and no longer has a bin output.
|
Thanks, guys! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Closes #27334
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)