Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

efl: add version 1.20.2 #27941

Merged
merged 3 commits into from Aug 17, 2017
Merged

efl: add version 1.20.2 #27941

merged 3 commits into from Aug 17, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Aug 4, 2017 •
edited

Motivation for this change

Update to new versions:

For new keep also EFL 1.19.x because EPhoto does not work with EFL 1.20.x yet.

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @ftrvxmtrx and @matejc to be potential reviewers.

@NeQuissimus
Copy link
Member

Check the Travis log, this seems to break ephoto

@romildo
Copy link
Contributor Author

romildo commented Aug 5, 2017

Check the Travis log, this seems to break ephoto

I have asked on #e and have got the answer:

yeah there was a wrong include in ephoto, it should work for ephoto-git

Ephoto: Remove unnecessary header.

But apparently it does not work.

@NeQuissimus
Copy link
Member

hmm, so we can't just include that patch in ephoto?

@romildo romildo changed the title efl: 1.19.1 -> 1.20.1 [WIP] efl: 1.19.1 -> 1.20.1 Aug 6, 2017
@romildo
Copy link
Contributor Author

romildo commented Aug 6, 2017 •
edited

With the patch ephot compiles, but does not run.

Marking this PR as work in progress for now.

@romildo
efl: add version 1.20.2
0fb920b 
- Add the new version 1.20.2.

- Keep version 1.19.1 for now because ephoto still needs it. As soon
  as a new release o ephoto which works with efl-1.20.x is availaible,
  efl-1.19.x may be removed.
@romildo
enlightenment: 0.21.8 -> 0.21.9
e78a08b
@romildo
pythonefl: 1.19.1 -> 1.20.0
0fe0d7c 
- Update to version 1.20.0.

- The hardening checking -Werror=format-string does not work with
  python-efl, so disable it.
@romildo romildo requested a review from FRidh as a code owner August 17, 2017 15:26
@romildo romildo changed the title [WIP] efl: 1.19.1 -> 1.20.1 efl: add version 1.20.2 Aug 17, 2017
@romildo
Copy link
Contributor Author

romildo commented Aug 17, 2017

I think the PR is ready for committing.

I am keeping two versions of efl: the current one (1.19.1) for ephoto, and the new one (1.20.2). When a new release of ephoto which works with 1.20.x is available, we can drop version 1.19.1.

@FRidh FRidh merged commit c732164 into NixOS:master Aug 17, 2017
@romildo romildo deleted the upd.efl branch August 17, 2017 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (update) 9.needs: reporter feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @mention-bot @NeQuissimus @FRidh