Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither
client_addr
orclient_addrlen
are used in the following function, butout
params were used. The man page says these two arguments should beNULL
if they're unused. Once I made this change, compilingspec/std/http/client/client_spec.cr
in release mode stopped segfaulting.I'm not entirely sure why this segfaulted in the first place, but it's likely to do with how
client_addrlen
is used by the kernel as the length of thesockaddr*
. I thinkout client_addrlen
is sending a random number on the top of the stack to the kernel. @oprypin raised the point that this shouldn't matter, since we allocatedsizeof(struct sockaddr)
forclient_addr
, and surely the kernel wouldn't write more than that? Who knows, this commit fixes it at least.