Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/networking/nat: add option for protocol #27933

Merged
merged 1 commit into from Aug 4, 2017
Merged

nixos/networking/nat: add option for protocol #27933

merged 1 commit into from Aug 4, 2017

Conversation

tnias
Copy link
Contributor

@tnias tnias commented Aug 4, 2017

This commit adds an option to allow udp port forwarding (see #24894).

Motivation for this change

Allow forwarding of non-tcp connections.

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This commit adds an option to allow udp port forwarding (see #24894).
@grahamc grahamc added this to the 17.09 milestone Aug 4, 2017
@globin globin merged commit 4f277bd into NixOS:master Aug 4, 2017
@tnias tnias deleted the nat_forward_proto branch August 4, 2017 21:06
@tnias tnias restored the nat_forward_proto branch August 4, 2017 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants