Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in compiler version check #2776

Merged
merged 1 commit into from Jul 21, 2017
Merged

Fix a bug in compiler version check #2776

merged 1 commit into from Jul 21, 2017

Conversation

biddisco
Copy link
Contributor

I had problems at some point and needed to deref the cmake vars.

@hkaiser hkaiser added this to the 1.1.0 milestone Jul 21, 2017
hkaiser
hkaiser approved these changes Jul 21, 2017
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser merged commit 7344e4f into master Jul 21, 2017
@hkaiser hkaiser deleted the fixing_compiler_check branch July 21, 2017 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
category: CMake type: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@biddisco @hkaiser