pass parameters through stash, not action args

Action arguments aren't really meant to be arbitrary data, or at least we are expecting them not to be. The not found page wanted look at the arguments and parameters, so it's easiest to let it keep doing that and pass data between the actions using the stash.
metacpan · Jul 21, 2017 · 02c60dd · 02c60dd
1 parent 761a030
commit 02c60dd
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/lib/MetaCPAN/Web/Controller/Release.pm b/lib/MetaCPAN/Web/Controller/Release.pm
@@ -16,7 +16,8 @@ sub root : Chained('/') PathPart('release') CaptureArgs(0) {
 sub by_distribution : Chained('root') PathPart('') Args(1) {
     my ( $self, $c, $distribution ) = @_;
 
-    $c->forward( 'view', [ $c->model->find($distribution) ] );
+    $c->stash(release_info => $c->model->find($distribution));
+    $c->forward( 'view' );
 }
 
 sub index : Chained('/') PathPart('release') CaptureArgs(1) {
@@ -44,12 +45,17 @@ sub by_author_and_release : Chained('root') PathPart('') Args(2) {
         $c->detach();
     }
 
-    $c->stash->{permalinks} = 1;
-    $c->forward( 'view', [ $c->model->get( $author, $release ) ] );
+    $c->stash(
+        permalinks => 1,
+        release_info => $c->model->get( $author, $release ),
+    );
+    $c->forward( 'view' );
 }
 
 sub view : Private {
-    my ( $self, $c, $release_info ) = @_;
+    my ( $self, $c ) = @_;
+
+    my $release_info = $c->stash->{release_info};
 
     my $data = $release_info->else(
         sub {