moon-buggy: init at 1.0.51 #28165
Merged
moon-buggy: init at 1.0.51 #28165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Aug 11, 2017
pkgs/games/moon-buggy/default.nix
Outdated
| }; | ||
|
|
||
| meta = { | ||
| inherit (s) version; |
There was a problem hiding this comment.
version is not an valid attribute here.
There was a problem hiding this comment.
Thanks for the comments, I'll correct them. I was basing this off of the n2048 package, maybe I'll fix that one too while I'm at it.
Mic92
reviewed
Aug 11, 2017
pkgs/games/moon-buggy/default.nix
Outdated
| inherit buildInputs; | ||
| src = fetchurl { | ||
| inherit (s) url sha256; | ||
| }; |
There was a problem hiding this comment.
You can actually just inline all attributes instead of using inherit. It does not really provide a benefit here. Just add rec after mkDerivation:
stdenv.mkDerivation rec {
Mic92
reviewed
Aug 11, 2017
pkgs/games/moon-buggy/default.nix
Outdated
| inherit (s) version; | ||
| description = ''A simple character graphics game where you drive some kind of car across the moon's surface''; | ||
| license = stdenv.lib.licenses.gpl2; | ||
| maintainers = []; |
There was a problem hiding this comment.
Do you want to maintain this package?
There was a problem hiding this comment.
Sure - I was wondering about this. Do I just add myself to lib/maintainers.nix and reference it in the list here?
fpletz
approved these changes
Aug 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
moon-buggy is fun
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)This is my first pull request. Please let me know anything I can improve on, because I'd like to contribute more in the future.