Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipfsapi: 0.4.5-pre -> 0.4.2.post1 #28166

Merged
merged 1 commit into from Aug 11, 2017
Merged

Conversation

mguentner
Copy link
Contributor

Motivation for this change

This is not a downgrade, 0.4.5-pre was a unofficial version.
0.4.5-pre was chosen to indicate feature parity with ipfs 0.4.5

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mguentner mguentner requested a review from FRidh as a code owner August 11, 2017 17:17
This is not a downgrade, 0.4.5-pre was a unofficial version.
@fpletz fpletz merged commit f6931ec into NixOS:master Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants