Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wireshark: 2.2.7 -> 2.4.0 #27832

Merged
merged 1 commit into from Aug 9, 2017
Merged

wireshark: 2.2.7 -> 2.4.0 #27832

merged 1 commit into from Aug 9, 2017

Conversation

lsix
Copy link
Member

@lsix lsix commented Aug 1, 2017

Motivation for this change

Fixes the following CVEs:

http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-11409
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-11406
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-11407
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-11408

I have tested main binaries and they work. I however have a little problem when I run wireshark just after building it:

$ nix-build -A wireshark
[…]
$ ./result/bin/wireshark 
This application failed to start because it could not find or load the Qt platform plugin "xcb"
in "".

Reinstalling the application may fix this problem.

To get it to work, I have to nix-env -i it:

$ nix-env -i $(readlink -f result)
$ wireshark
[works properly]

@ttuegel any idea how to solve that (I have the same problem if I nix-shell -p it)?

I am also preparing an update to wireshark-2.2.8 to integrate in release-17.03.

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lsix
Copy link
Member Author

lsix commented Aug 1, 2017

The qt plugin issue is not related to this update:

$ NIX_PATH=nixpkgs=https://github.com/NixOS/nixpkgs-channels/archive/nixos-unstable.tar.gz  nix-shell -p wireshark --command wireshark
This application failed to start because it could not find or load the Qt platform plugin "xcb"
in "".

Reinstalling the application may fix this problem.

@FRidh
Copy link
Member

FRidh commented Aug 1, 2017

@lsix Qt applications cannot be run from the store anymore, but need to be installed.

@adisbladis
Copy link
Member

@lsix I ran into the same Qt issue with sddm. I think it's related to dce958a (which was a fix for 3cb745d ) and b087618 being applied at the same time.

I'm trying to confirm this but rebuilding takes a while.

cc @ttuegel

@ttuegel
Copy link
Member

ttuegel commented Aug 2, 2017

Qt applications cannot be run from the store anymore, but need to be installed.

@FRidh is correct, Qt applications cannot be run from the store. What you are seeing is the expected behavior.

@lsix
Copy link
Member Author

lsix commented Aug 2, 2017

Given the fact that I did not break the thing with the package update, I did not worry to much about that (this is why I dropped the WIP tag). Also, someone using wireshark will probably want to install it with programs.wireshark.enable = true; to be able to use it without root privileges.

However, if I refer to https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/qt.xml#L52 I understand that I should be able to run it with nix-shell, which I cannot, as stated in my previous comment. Is that also expected?

@ttuegel
Copy link
Member

ttuegel commented Aug 3, 2017

Is that also expected?

Yes.

@lsix lsix merged commit 90282d9 into NixOS:master Aug 9, 2017
@lsix lsix deleted the update_wireshark branch August 22, 2019 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lsix @FRidh @adisbladis @ttuegel