Add support for max + min intrinsics #4774
Merged
+18
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The LLVM binary operations should be usable now too but the commented out code for them seems invalid. I don't understand how they can be called. |
|
This depends on #4396, and this change was also discussed there. |
|
@RX14 Oh, I was totally under the impression that was done a while back 😅 |
wmoxam
force-pushed
the
add-math-operations
branch
from
a5db15d to
acc1697
Compare
|
@wmoxam thanks for the ping! |
RX14
approved these changes
Sep 9, 2017
mverzilli
approved these changes
Sep 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM support is now sufficiently updated to support these.