qt5: Fallback to mktemp -d for temporary QT root. #28237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fallback to `mktemp -d` for temporary QT root, if invoked in shell mode. Should fix problem from NixOS#27174.
|
Do we have a shell hook, which is called before |
|
@Mic92 I added some sort of exit hook, it works locally |
ttuegel
approved these changes
Sep 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback to
mktemp -dfor temporary QT root, if invoked in shell mode.Should fix problem from #27174.
Motivation for this change
Folks often complains on qt5_nix dropped into source dir, when nix-shell -p qt5.qtbase invoked, so little hack was added, to fallback to old solution with mktemp -d in shell mode.
Thing to be done -- figure out, why this dir not properly removed on shell exit.
PS Tested against master, but PR to staging, to avoid unnessesary mass-rebuild.
(at least qastools and virtualbox builds with this patch applied).
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)