Allow configuration to specify LAN of rings #204
Merged
+60
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add longitudeOfAscendingNode property - Make lockRotation property consistently fix ring to same orientation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PhineasFreak mentioned in a response to #201 that there were some problems with ring orientation, specifically that inclined rings are not consistently oriented the same way across sessions, and the longitude of their ascending nodes could not be set. Among other things, this makes it impossible to align an inclined moon with a nearby inclined ring, or to create texture effects on the parent body that are aligned with Uranus-like rings. This forum post by @OhioBob corroborates that report, and I found the same problems upon investigation:
Rather than fix this issue in that pull request, I thought it would be best to split it out into a separate, smaller patch:
After these changes, I can put my inclined Laythe and my inclined JoolRings test case into the same plane by setting their longitudeOfAscendingNode properties to the same value in the cfg: