Player::getSpeed/setSpeed use const refs

nerzhul · nerzhul · commit 3eb9ff555f16 · 2017-08-14T10:56:06.000+02:00
diff --git a/src/camera.cpp b/src/camera.cpp
@@ -526,7 +526,7 @@ void Camera::update(LocalPlayer* player, f32 frametime, f32 busytime,
 	// If the player is walking, swimming, or climbing,
 	// view bobbing is enabled and free_move is off,
 	// start (or continue) the view bobbing animation.
-	v3f speed = player->getSpeed();
+	const v3f &speed = player->getSpeed();
 	const bool movement_XZ = hypot(speed.X, speed.Z) > BS;
 	const bool movement_Y = fabs(speed.Y) > BS;
 
diff --git a/src/clientiface.cpp b/src/clientiface.cpp
@@ -95,7 +95,7 @@ void RemoteClient::GetNextBlocks (
 	}
 
 	v3f playerpos = sao->getBasePosition();
-	v3f playerspeed = player->getSpeed();
+	const v3f &playerspeed = player->getSpeed();
 	v3f playerspeeddir(0,0,0);
 	if(playerspeed.getLength() > 1.0*BS)
 		playerspeeddir = playerspeed / playerspeed.getLength();
diff --git a/src/player.h b/src/player.h
@@ -104,12 +104,12 @@ class Player
 			std::vector<CollisionInfo> *collision_info)
 	{}
 
-	v3f getSpeed()
+	const v3f &getSpeed() const
 	{
 		return m_speed;
 	}
 
-	void setSpeed(v3f speed)
+	void setSpeed(const v3f &speed)
 	{
 		m_speed = speed;
 	}

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ void RemoteClient::GetNextBlocks (`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`v3f playerpos = sao->getBasePosition();`
`98`		`- v3f playerspeed = player->getSpeed();`
	`98`	`+ const v3f &playerspeed = player->getSpeed();`
`99`	`99`	`v3f playerspeeddir(0,0,0);`
`100`	`100`	`if(playerspeed.getLength() > 1.0*BS)`
`101`	`101`	`playerspeeddir = playerspeed / playerspeed.getLength();`
Original file line number	Diff line number	Diff line change
`@@ -104,12 +104,12 @@ class Player`
`104`	`104`	`std::vector<CollisionInfo> *collision_info)`
`105`	`105`	`{}`
`106`	`106`
`107`		`- v3f getSpeed()`
	`107`	`+ const v3f &getSpeed() const`
`108`	`108`	`{`
`109`	`109`	`return m_speed;`
`110`	`110`	`}`
`111`	`111`
`112`		`- void setSpeed(v3f speed)`
	`112`	`+ void setSpeed(const v3f &speed)`
`113`	`113`	`{`
`114`	`114`	`m_speed = speed;`
`115`	`115`	`}`