samba module: fix pam service name typo #28049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PAM service name used before this commit was "sambda", with an extra 'd'. For some reason I don't quite fully understand this typo prevents GDM from starting. This change fixes that as tested in VMs built using "nixos-rebuild -I nixpkgs=<mypkgs> build-vm".
|
@edolstra, I believe you were the original author or at least merged the line that is being updated in this PR. |
ixmatus
approved these changes
Aug 8, 2017
|
Thank you |
joachifm
pushed a commit
that referenced
this pull request
Aug 11, 2017
The PAM service name used before this commit was "sambda", with an extra 'd'. For some reason I don't quite fully understand this typo prevents GDM from starting. This change fixes that as tested in VMs built using "nixos-rebuild -I nixpkgs=<mypkgs> build-vm". (cherry picked from commit f9204b9)
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
The PAM service name used before this commit was "sambda", with an extra 'd'. For some reason I don't quite fully understand this typo prevents GDM from starting. This change fixes that as tested in VMs built using "nixos-rebuild -I nixpkgs=<mypkgs> build-vm". (cherry picked from commit f9204b9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
GDM wouldn't start after configuring samba
Things done
The PAM service name used before this commit was "sambda", with an
extra 'd'. For some reason I don't quite fully understand this typo
prevents GDM from starting. This change fixes that as tested in VMs
built using "nixos-rebuild -I nixpkgs= build-vm".
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)