Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baudline: use jack2 instead of jack1 #27655

Closed
wants to merge 1 commit into from
Closed

baudline: use jack2 instead of jack1 #27655

wants to merge 1 commit into from

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Jul 26, 2017 •
edited

Motivation for this change

Otherwise it doesn't connect with the rest of the system

Things done

Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@magnetophon
baudline: use jack2 instead of jack1
59e3270 
Otherwise it doesn't connect with the rest of the system
@mention-bot
Copy link

@magnetophon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bjornfor, @globin and @dezgeg to be potential reviewers.

@bjornfor
Copy link
Contributor

So it really doesn't work? I thought jack1 and jack2 were compatible: https://github.com/jackaudio/jackaudio.github.com/wiki/Q_difference_jack1_jack2

If jack1 can work under some circumstances, I'd prefer to just change "jack = libjack2" in all-packages.nix instead, because that preserves the "API".

@magnetophon
Copy link
Member Author

@bjornfor It didn't work for me without this change.
Did it work for you?
Have you seen #11079 ?

@bjornfor
Copy link
Contributor

@magnetophon: I haven't tested jack in years. I read #11079 yesterday, thanks. Sounds to me that, perhaps among other things, we have a jack1 packaging issue.

How about changing this PR so that it only flips "jack = libjack2" in all-packages.nix (preserve expression signature). Assuming the two jack implementations are interchangeable, that change feels more appropriate.

What do you think?

@magnetophon
Copy link
Member Author

@bjornfor I don't get it: why would we have a few packages that pretend the jacks are interchangeable?
On NixOS they never have been, afaik, for whatever reason.

@bjornfor
Copy link
Contributor

Because I have hope that jack1 packaging will be fixed. (And AFAICT, upstream says they are interchangeable.)

But no strong feelings. So I'm OK for merge. (If/when jack1 gets fixed in nixpkgs, it'll be easy to change back the expressions.)

@bjornfor
Copy link
Contributor

Applied to master (72e99b6).

@bjornfor bjornfor closed this Jul 29, 2017
@magnetophon magnetophon deleted the baudline branch June 6, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magnetophon @mention-bot @bjornfor