go: support for aarch64 via binary bootstrap #27651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elitak, thanks for your PR! By analyzing the history of the files in this pull request, we identified @avnik, @LnL7 and @brendanlong to be potential reviewers. |
elitak
force-pushed
the
go-aarch64
branch
4 times, most recently
from
b5c4df2
to
76686f8
Compare
|
The Darwin build keeps failing, despite my rebases. The log doesn't suggest it's caused by my changes. Is the CI buid for Darwin broken? |
|
I think there was a recent change to the |
|
Okay, thanks. I just rebased again and it works now. |
bobrik
reviewed
Dec 24, 2020
| srcOnly { | ||
| name = "go-1.8-linux-arm64-bootstrap"; | ||
| src = fetchurl { | ||
| url = "https://cache.xor.us/go-1.8-linux-arm64-bootstrap.tar.xz"; |
There was a problem hiding this comment.
cache.xor.usnow presents the cert forblog.xor.us, breaking TLS- even if you allow certificate mismatch, URL returns 404
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted to run ipfs on aarch64.
Things done
This is probably still too hacky, but I'd like some feedback before I dig deeper into getting a more sensible bootstrap. What I did is built my own and hand-crafted (just a few renames) a tarball for use as a standin for
pkgs.go_bootstrap. I'm hosting this tarball on my own host, so at the very least it could be hosted someplace with higher reliability.go_1_6 go_1_7 go_1_8all build. ipfs builds and runs.(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)