sqlmap: 1.0.11 -> 1.1 #28314
sqlmap: 1.0.11 -> 1.1 #28314
Conversation
pkgs/top-level/python-packages.nix
Outdated
| @@ -21394,11 +21394,13 @@ in { | |||
| }; | |||
|
|
|||
| sqlmap = buildPythonPackage { | |||
There was a problem hiding this comment.
Is it usable as a library? Otherwise I would move it out of pythonPackages.
There was a problem hiding this comment.
@Mic92 moved it out of pythonPackages.
Is the callPackage (https://github.com/NixOS/nixpkgs/pull/28314/files#diff-2afbba83e1b14f9e0c304c769831a0e2R21396) in pythonPackages ok or should I remove that?
fadenb
force-pushed
the
sqlmap_update
branch
2 times, most recently
from
7b981ad
to
64bd9ac
Compare
pkgs/top-level/python-packages.nix
Outdated
| maintainers = with stdenv.lib.maintainers; [ bennofs ]; | ||
| }; | ||
| }; | ||
| sqlmap = callPackage ../applications/misc/sqlmap { }; |
There was a problem hiding this comment.
I would not leave this here. It confuses users, it will be still available as python3Packages.sqlmap.
We have no aliases.nix for python-packages.nix unfortunally.
Additionally disable sqlmap for python3 as it is incompatible:
"[CRITICAL] incompatible Python version detected ('3.6.1'). For successfully running sqlmap you'll have to use version 2.6 or 2.7 (visit 'http://www.python.org/download/')"
|
Ew, this conflicted with 7a6b150, /cc @FRidh & @Mic92. I resolved now for the other commit, but I mainly didn't want to spend much time resolving conflicts between staging and master that are unrelated to my changes. There were more conflicts, usually trivial where I went for A couple more complex cases: for mitmproxy I took the version from 27ac74d and not 19183d1; for flask-testing I took 9b65bc9 over d58e1f1 (different hashes! so I tested). |
There were some conflicts in python modules, commented at #28314.
|
Thank you @vcunat. It's really hard to prevent these kind of issues when staging is blocked from merging. I won't attend NixCon but I hope this topic will be discussed. |
|
"blocked" because of slow rebuilds, or do you know about another problem? |
|
When staging is in a state that it cannot be fixed, fixes are contributed but often at the same time new breaking commits are merged/pushed as well, thus "blocking" staging from being merged. |
|
That will be difficult, I think, but we should find some way to improve it. As announced, staging is for non-breaking changes only, but in practice it's difficult to always use it that way. (Because one doesn't have any darwin machines, for example.) |
Additionally disable sqlmap for python3 as it is incompatible:
"[CRITICAL] incompatible Python version detected ('3.6.1'). For successfully running sqlmap you'll have to use version 2.6 or 2.7 (visit 'http://www.python.org/download/')"
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)