-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activation of jar-dependencies in bundler clashes with shipped gem #4740
Comments
@jsvd since I am basically offline until end of August - I can not have a look at until I am back to internet land. |
@mkristian Can you look at this now? :-) |
@headius I got the reminder yesterday through the other issue already |
@headius so the problem is that bundler requires 'readline' inside its vendor thor, in the end it is never ever used but readline needs jar-dependencies to load its jars. possible fixes:
I would go for the second option as it is in our domain and its gives IMO improvement onjline issue we saw in the past. it also relates to #3681 where we also had two solutions:
if am already repacking/shading things then I will also address #3821 in the same PR my proposed actions would be:
/cc @enebo |
@mkristian Ok so my main concern here is that Ruby 2.5 is gemifying basically everything, which means we're going to need to essentially follow that pattern. We'll want to figure out which gems we can just use, which need some JRuby patches, and which we'll have to replace altogether (probably still needing to push to those names). Moving readline back into core now means we'll just be moving it back out again. I do agree we should probably start shading everything we ship and do not intend to export. |
@headius OK then it is better we leave the readline gem as gem and just shade/repackage the jline and require it without the jar-dependencies. in general it is nice to share even the jars via jar-dependencies but jline was problematic in the past as well, and with this bundler issue, we just repackage it. |
this will include the jline shaded and relocated in the readline.jar fixes #4740
This is good and safe for 9.1.15, right? |
@headius if the build is green then it is good to go. |
this will include the jline shaded and relocated in the readline.jar fixes #4740
Ship it! |
this will include the jline shaded and relocated in the readline.jar fixes #4740
@mkristian Please re-comment the staging repo once you've gotten the release out. |
Environment
jruby 9.1.10.0 (2.3.3) 2017-05-25 b09c48a Java HotSpot(TM) 64-Bit Server VM 25.111-b14 on 1.8.0_111-b14 +jit [darwin-x86_64]
Darwin Joaos-MBP-5.lan 16.6.0 Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64 x86_64
Gemfile:
Existing jar-dependencies:
Expected Behavior
bundle exec rspec
should workActual Behavior
This may be related to jruby/jar-dependencies#52, but I can't reproduce the issue on jruby 1.7.x, leading me to think it is a 9k problem.
The text was updated successfully, but these errors were encountered: