Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: 8.2.1 -> 8.3.0 #28096

Merged
merged 1 commit into from
Aug 11, 2017
Merged

nodejs: 8.2.1 -> 8.3.0 #28096

merged 1 commit into from
Aug 11, 2017

Conversation

lo1tuma
Copy link
Member

@lo1tuma lo1tuma commented Aug 10, 2017

Motivation for this change

Release Notes

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Aug 10, 2017

cc @goibhniu @Havvy @gilligan @cko

@gilligan
Copy link
Contributor

darwin build timed out on travis but @lo1tuma tested that locally so LGTM!

@wmertens wmertens merged commit 8e9b321 into NixOS:master Aug 11, 2017
@wmertens
Copy link
Contributor

🆗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lo1tuma @FRidh @gilligan @wmertens