Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.lerna: init at 2.0.0 #28090

Merged
merged 1 commit into from Aug 11, 2017
Merged

nodePackages.lerna: init at 2.0.0 #28090

merged 1 commit into from Aug 11, 2017

Conversation

ben-z
Copy link
Contributor

@ben-z ben-z commented Aug 9, 2017

Motivation for this change

The Javascript tool for managing multiple projects in the same repo Lerna has been out for a while now, and they recently updated to V2. It hasn't been in the nixpkgs repo to expose cli commands, this PR adds it.

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ben-z, thanks for your PR! By analyzing the history of the files in this pull request, we identified @svanderburg, @8573 and @jlesquembre to be potential reviewers.

@Mic92 Mic92 merged commit d0aeccb into NixOS:master Aug 11, 2017
@Mic92
Copy link
Member

Mic92 commented Aug 11, 2017

Thanks!

@ben-z ben-z deleted the init-lerna branch August 26, 2017 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants