Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This release in a RC for gnupg-2.2. The main difference as far as
nixpkgs is concerned is that the binary
gpg2
is now calledgpg
andgpgv2
is calledgpgv
.This update fixed all explicit use of
gpg2
andgpgv2
across nixpkgs,but there might be some packaged software that internally use
gpg2
.It could be possible to use the
--enable-gpg-is-gpg2
configure flag to keep the old binary names, but in the long run I think everyone should converge to the new naming. We could use this while waiting for the 2.2 release but this would only postpone the work.It could however be reasonable to use the
--enable-gpg-is-gpg2
until the17.09
branch of, and then have a 6 month window to be sure this renaming does not cause issue for next stable release.I am of course open to discussions on this subject.
See http://lists.gnu.org/archive/html/info-gnu/2017-08/msg00001.html
for full release information
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)