Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnupg: 2.1.22 -> 2.1.23 #28101

Merged
merged 1 commit into from Aug 11, 2017
Merged

gnupg: 2.1.22 -> 2.1.23 #28101

merged 1 commit into from Aug 11, 2017

Conversation

lsix
Copy link
Member

@lsix lsix commented Aug 10, 2017

Motivation for this change

This release in a RC for gnupg-2.2. The main difference as far as
nixpkgs is concerned is that the binary gpg2 is now called gpg and
gpgv2 is called gpgv.

This update fixed all explicit use of gpg2 and gpgv2 across nixpkgs,
but there might be some packaged software that internally use gpg2.

It could be possible to use the --enable-gpg-is-gpg2 configure flag to keep the old binary names, but in the long run I think everyone should converge to the new naming. We could use this while waiting for the 2.2 release but this would only postpone the work.

It could however be reasonable to use the --enable-gpg-is-gpg2 until the 17.09 branch of, and then have a 6 month window to be sure this renaming does not cause issue for next stable release.

I am of course open to discussions on this subject.

See http://lists.gnu.org/archive/html/info-gnu/2017-08/msg00001.html
for full release information

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This release in a RC for gnupg-2.2. The main difference as far as
nixpkgs is concerned is that the binary `gpg2` is now called `gpg` and
`gpgv2` is called `gpgv`.

This update fixed all explicit use of `gpg2` and `gpgv2` across nixpkgs,
but there might be some packaged software that internally use `gpg2`
not handeled by this commit.

See http://lists.gnu.org/archive/html/info-gnu/2017-08/msg00001.html
for full release information
@fpletz
Copy link
Member

fpletz commented Aug 11, 2017

I'd say we start with this PR and without --enable-gpg-is-gpg2 and see if someting breaks. We can always revert enable it before the branchoff or the release eventually. 👍

@fpletz fpletz added this to the 17.09 milestone Aug 11, 2017
@globin globin merged commit e34ce9d into NixOS:master Aug 11, 2017
@lsix lsix deleted the update_gnupg21 branch August 22, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants