Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell: fix build of ghcjs and ghcjsHEAD #28098

Merged
merged 1 commit into from
Aug 17, 2017
Merged

haskell: fix build of ghcjs and ghcjsHEAD #28098

merged 1 commit into from
Aug 17, 2017

Conversation

cocreature
Copy link
Contributor

@cocreature cocreature commented Aug 10, 2017 •
edited

Motivation for this change

ghcjs and ghcjsHEAD can’t built with cabal-install 2.0, see #28037.

Things done

Patch ghcjs-boot to support cabal-install 2.0.

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mpickering
Copy link
Contributor

See haskell/cabal#3987

Seems a simpler solution would be to pass --install-base-libraries instead of --solver topdown to cabal.

@cocreature cocreature changed the title [WIP] haskell: fix build of ghcjs and ghcjsHEAD haskell: fix build of ghcjs and ghcjsHEAD Aug 11, 2017
@cocreature
Copy link
Contributor Author

Alright I’ve now switched to the simpler approach and tested that things still work. I would consider this ready to be merged now.

@cocreature
Copy link
Contributor Author

@peti It would be great if you could take a look at this.

@mpickering
Copy link
Contributor

Looks right to me.

@cstrahan
Copy link
Contributor

Thanks!

@cstrahan cstrahan merged commit 35b9dfd into NixOS:master Aug 17, 2017
@23Skidoo 23Skidoo mentioned this pull request Sep 18, 2017
Closed
@cocreature cocreature mentioned this pull request Oct 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cocreature @mpickering @cstrahan @FRidh