Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config node unlocks for RN's R-7 engines. #734

Closed
wants to merge 1 commit into from
Closed

Fix config node unlocks for RN's R-7 engines. #734

wants to merge 1 commit into from

Conversation

ahmedcharles
Copy link
Contributor

This doesn't work yet, but I'm not sure what else could be going wrong.

@ahmedcharles
Copy link
Contributor Author

This makes it so that the configs unlock in the correct nodes.

@ahmedcharles
Copy link
Contributor Author

Any feedback on this?

@NathanKell
Copy link
Member

This...doesn't seem to have anything to do with TF...?

Except to the extent that it looks like those configs are RN-specific, so I wouldn't be surprised if they have no TF configs because they're not using the global configs (where the TF configging is done).

@ahmedcharles
Copy link
Contributor Author

On, I just didn't change the comment.

@ahmedcharles
Copy link
Contributor Author

That's a better commit comment.

@ahmedcharles ahmedcharles changed the title Fix Test Flight for RN's R-7 engines. Fix config node unlocks for RN's R-7 engines. Jul 31, 2017
@NathanKell
Copy link
Member

Ah, that makes more sense. I wonder if we now have enough global configs that we can harmonize with raidernick's configs?

@ahmedcharles
Copy link
Contributor Author

All of the RN TF configs map to the stats of an existing TF config, i.e. he didn't create different reliability profiles from the 'global' ones.

However, the engine configs themselves are different, since they lack the thrust of the verniers, since they are separate engines. Granted, this also means that RN's version of the LV is more likely to have a failure, since there are more engines being modeled.

@ahmedcharles
Copy link
Contributor Author

Anyways, any unification would have to be done in RO, not RP-0, so this should be good as is?

@pap1723
Copy link
Contributor

pap1723 commented Aug 4, 2017

This is taken care of with the new RD-107/RD-108 configs

@pap1723 pap1723 closed this Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants