Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow post and config arguments of metadata_extractors.check_conditions to be None #2878

Merged
merged 1 commit into from Jul 24, 2017
Merged

Allow post and config arguments of metadata_extractors.check_conditions to be None #2878

merged 1 commit into from Jul 24, 2017

Conversation

felixfontein
Copy link
Contributor

Makes the function more flexible. For getnikola/plugins#241 (at least post being None).

@felixfontein felixfontein mentioned this pull request Jul 24, 2017
Merged
@felixfontein
Copy link
Contributor Author

Hmm, maybe allowing config to be None is a bit too much. What do you think?

@Kwpolska
Copy link
Member

Yeah, it’s too much.

@felixfontein
Copy link
Contributor Author

I changed it. I decided to force-push this so that this minimal change won't have two commits.

@Kwpolska Kwpolska merged commit 851bca1 into master Jul 24, 2017
@felixfontein
Copy link
Contributor Author

Thanks for idea, review and merging! :)

@felixfontein felixfontein deleted the extend-check-conditions branch July 24, 2017 18:18
felixfontein added a commit to getnikola/plugins that referenced this pull request Jul 24, 2017
@felixfontein
Using new feature from getnikola/nikola#2878.
bb0bfe0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixfontein @Kwpolska