neofetch: 3.0.1 -> 3.2.0 #27608
Closed
neofetch: 3.0.1 -> 3.2.0 #27608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@konimex, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alibabzo to be a potential reviewer. |
|
I'd suggest to add the comment regarding the patch to the |
grahamc
reviewed
Jul 26, 2017
pkgs/tools/misc/neofetch/default.nix
Outdated
| # configuration file, w3m directory (for fetching images) and ASCII | ||
| # directory properly. It won't be needed in subsequent releases. | ||
| patches = [ | ||
| ./config.patch |
There was a problem hiding this comment.
Is this patch available over http? Generally we prefer to use fetchpatch over embedding the patch in the repo.
There was a problem hiding this comment.
Just uploaded it to the release, so yeah it's available over HTTP.
|
The sha256 for the patch is wrong. It should be: |
|
Oops. My bad. Anyway, I'm closing this one since for some reason I lost the branch (even after fetching all remotes I cannot fetch the branch). Will open a new PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The patch is needed to address dylanaraps/neofetch#752. The patches are in upstream, but not in 3.2.0. The patch won't be needed in any subsequent releases.
Things done
Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)cc: @alibabzo