Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/cloud-image: add module #28008

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Conversation

alexandergall
Copy link
Contributor

Motivation for this change

The module creates an image for an openstack-based cloud using the
cloud-init package.

The image has been tested on an openstack infrastructure.

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The module creates an image for an openstack-based cloud using the
cloud-init package.
@wmertens
Copy link
Contributor

wmertens commented Aug 7, 2017

Nice, but is there no registry of images or something similar that it can be linked from? Seems to me that not everybody will think to look in that directory if they want an openstack image…

@copumpkin
Copy link
Member

There isn't, but we really should make the image building stuff more easily accessible. Nix is great for building images but you need to know the right incantation to do so, and we should make it more visible.

I'd probably accept this, and then file an issue to figure out how best to expose our image goodness in a friendly manner.

@wmertens wmertens merged commit 18fa60d into NixOS:master Aug 8, 2017
@alexandergall alexandergall deleted the add-cloud-image branch August 8, 2017 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants