Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b32c9ddc841c
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5e29f10bd910
Choose a head ref
  • 7 commits
  • 108 files changed
  • 1 contributor

Commits on Jul 27, 2017

  1. tOP_ASGN is a symbol now from the lexer.

    @enebo
    enebo committed Jul 27, 2017
    Copy the full SHA
    6bcc1d7 View commit details

  2. Calls implement ISymbolNameNode and have RubySymbol name field.

    @enebo
    enebo committed Jul 27, 2017
    Copy the full SHA
    3c239e8 View commit details

Commits on Jul 28, 2017

  1. Half-hazard conversion of method definitions and their lookup to be R… 

    …ubySymbol.

At this point I suspect quite a bit of overhead because I am constantly
converting from String to RubySymbol.  gem list might be about 5% slower which
is much less than I anticipated with this extra temporary working being done.
    @enebo
    enebo committed Jul 28, 2017
    Copy the full SHA
    81eb28a View commit details

  2. SymbolNode is just a wrapper of RubySymbol

    @enebo
    enebo committed Jul 28, 2017
    Copy the full SHA
    596765e View commit details

Commits on Jul 29, 2017

  1. All calls use symbols in IR (although callsites still use Strings).

    @enebo
    enebo committed Jul 29, 2017
    Copy the full SHA
    fe8ab47 View commit details

Commits on Jul 31, 2017

  1. Remove initFromDescriptor (long dead internal code).

    @enebo
    enebo committed Jul 31, 2017
    Copy the full SHA
    a11a57d View commit details

Commits on Aug 7, 2017

  1. callsite uses Symbol instead of String. Note: There are still a few c… 

    …ases where

we provide a String in the JIT and it bombs on RubySymbol.  I needed to focus on
some other stuff for now so I decided to commit a tiny bit broken.
    @enebo
    enebo committed Aug 7, 2017
    Copy the full SHA
    5e29f10 View commit details
Loading